From 825fbca97b325cfd8c02162e9fd21e07ddc34642 Mon Sep 17 00:00:00 2001 From: adrien Date: Thu, 26 Sep 2024 23:15:15 +0200 Subject: [PATCH] fix a leak --- jsm/Tetrominoes.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jsm/Tetrominoes.js b/jsm/Tetrominoes.js index 4aafafc..5066ddf 100644 --- a/jsm/Tetrominoes.js +++ b/jsm/Tetrominoes.js @@ -200,9 +200,9 @@ class Mino extends THREE.Object3D { this.rotateOnWorldAxis(this.rotationAngle, delta * this.angularVelocity) if (Math.sqrt(this.position.x * this.position.x + this.position.z * this.position.z) > 40 || this.position.y < -50) { this.dispose() - return false - } else { return true + } else { + return false } } @@ -569,7 +569,7 @@ class Playfield extends THREE.Group { updateFreedMinoes(delta) { this.freedMinoes.forEach(mino => { - if (mino.explode(delta)) this.freedMinoes.delete(this) + if (mino.explode(delta)) this.freedMinoes.delete(mino) }) }